Make script services always respond when asked#95991
Merged
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
approved these changes
Jul 6, 2023
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
LGTM, thanks @bramkragten 👍
balloob
approved these changes
Jul 6, 2023
balloob
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Make script services always respond when asked * Update test_init.py
Merged
joostlek
pushed a commit
to joostlek/core
that referenced
this pull request
Jul 6, 2023
* Make script services always respond when asked * Update test_init.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Script services are registered with
SupportsResponse.OPTIONALmeaning:The service optionally returns response data when asked by the caller.This PR will make it always return a response when asked by the caller, also when the script itself doesn't return a response.
Previously we would throw because a service should respond a dict and the service responded None.
As follow up we could register script services for scripts that do not include a
stopaction withresponse_variableasSupportsResponse.NONE, but a script with a stop action could still return nothing on some paths, so this PR will still be needed.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: