Skip to content

Fix grouping feature for MusicCast#95958

Merged
balloob merged 1 commit into
home-assistant:devfrom
micha91:musiccast_grouping_fix
Jul 6, 2023
Merged

Fix grouping feature for MusicCast#95958
balloob merged 1 commit into
home-assistant:devfrom
micha91:musiccast_grouping_fix

Conversation

@micha91
Copy link
Copy Markdown
Contributor

@micha91 micha91 commented Jul 6, 2023

Proposed change

Due to the new source names from #74954 we were checking the current source by using the source names instead of the source ids. Long story short: We weren't taking care of the breaking change, we introduced there. This will be fixed by this PR so that the grouping features of MusicCast should now work again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration (yamaha_musiccast) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of yamaha_musiccast can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign yamaha_musiccast Removes the current integration label and assignees on the pull request, add the integration domain after the command.

vigonotion
vigonotion approved these changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vigonotion vigonotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍🏻

@joostlek joostlek added this to the 2023.7.1 milestone Jul 6, 2023
joostlek
joostlek previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frenck
frenck requested changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been discussing this, mostly the original PR, so making this review to block this one for now.

@home-assistant home-assistant Bot marked this pull request as draft July 6, 2023 09:11
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@micha91
Copy link
Copy Markdown
Contributor Author

micha91 commented Jul 6, 2023

Have been discussing this, mostly the original PR, so making this review to block this one for now.

Can you please link the original PR, you mentioned? If you are referring to #74954: That one was already merged and is part of the 2022.07 release. This PR fixes the bug, which was caused by #74954.

@joostlek joostlek self-requested a review July 6, 2023 11:13
@joostlek joostlek dismissed their stale review July 6, 2023 11:13

See Frencks review

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Jul 6, 2023

Yes, it's that PR that we are concerned about. We know it's been released. We're discussing reverting it.

@micha91
Copy link
Copy Markdown
Contributor Author

micha91 commented Jul 6, 2023

Okay - if you are considering reverting it because of the ability to use translations in state attributes: I would love to use translations instead of renaming sources. But for sources, it makes no sense to use static translations. On MusicCast devices, you can rename sources in the MusicCast app. For example, my hdmi1 is renamed to Apple-TV, and that is the only thing that shows up in the device display and the MusicCast app. But for other users, hdmi1 might be renamed to XBOX, etc. If it were possible to let the device return translations/labels for sources, I would also prefer to go that way, but to my knowledge this is not the case, right?

@frenck frenck marked this pull request as ready for review July 6, 2023 15:11
@home-assistant home-assistant Bot requested a review from frenck July 6, 2023 15:11
balloob
balloob approved these changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good to go as these are user defined labels, and we cannot offer translations for those.

@balloob balloob merged commit 5964534 into home-assistant:dev Jul 6, 2023
balloob pushed a commit that referenced this pull request Jul 6, 2023
@micha91 @balloob
Fix grouping feature for MusicCast (#95958)
bca5aae 
check the current source for grouping using the source ID instead of the label
@balloob balloob mentioned this pull request Jul 6, 2023
Merged
joostlek pushed a commit to joostlek/core that referenced this pull request Jul 6, 2023
@micha91 @joostlek
Fix grouping feature for MusicCast (home-assistant#95958)
8b17d6e 
check the current source for grouping using the source ID instead of the label
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

@joostlek joostlek Awaiting requested review from joostlek

@frenck frenck Awaiting requested review from frenck

+1 more reviewer

@vigonotion vigonotion vigonotion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed integration: yamaha_musiccast Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2023.7.1

Development

Successfully merging this pull request may close these issues.

MusicCast Group/Ungroup Broken

6 participants

@micha91 @MartinHjelmare @frenck @balloob @vigonotion @joostlek