Skip to content

Remove unsupported services and fields from fan/services.yaml#95858

Merged
MartinHjelmare merged 1 commit into
devfrom
fan_service_cleanup
Jul 4, 2023
Merged

Remove unsupported services and fields from fan/services.yaml#95858
MartinHjelmare merged 1 commit into
devfrom
fan_service_cleanup

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Jul 4, 2023

Proposed change

Remove service fan.set_speed and remove service field speed from service fan.turn_on from fan/services.yaml.

This should have been removed as part of #67743 which removed the corresponding implementation, but was forgotten

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 4, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (fan) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fan can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fan Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emontnemery 👍

../Frenck

@frenck frenck added this to the 2023.7.0 milestone Jul 4, 2023
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 4, 2023

@bdraco Why did you add the breaking change label?

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jul 4, 2023

Missed that its only the YAML and not the actual service. My bad (little too much task switching this morning)

@emontnemery
Copy link
Copy Markdown
Contributor Author

I tried to improve the PR description to make it clear the PR only changes services.yaml, the actual implementation is long gone

@MartinHjelmare MartinHjelmare merged commit c46495a into dev Jul 4, 2023
@MartinHjelmare MartinHjelmare deleted the fan_service_cleanup branch July 4, 2023 15:58
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants