Remove unsupported services and fields from fan/services.yaml#95858
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
frenck
approved these changes
Jul 4, 2023
Member
frenck
left a comment
There was a problem hiding this comment.
Thanks, @emontnemery 👍
../Frenck
bdraco
approved these changes
Jul 4, 2023
Member
|
@bdraco Why did you add the breaking change label? |
Member
|
Missed that its only the YAML and not the actual service. My bad (little too much task switching this morning) |
Contributor
Author
|
I tried to improve the PR description to make it clear the PR only changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove service
fan.set_speedand remove service fieldspeedfrom servicefan.turn_onfromfan/services.yaml.This should have been removed as part of #67743 which removed the corresponding implementation, but was forgotten
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: