Skip to content

Add slots to core EventBus#95856

Merged
bdraco merged 16 commits into
devfrom
slots_event_bus
Jul 5, 2023
Merged

Add slots to core EventBus#95856
bdraco merged 16 commits into
devfrom
slots_event_bus

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 4, 2023

Proposed change

Use slots in the EventBus

Fix all the tests that were patching the EventBus (and firing state change events with invalid entity ids)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We will need to fix all the tests that patch the EventBus for this to work
@home-assistant home-assistant Bot added cla-signed core small-pr PRs with less than 30 lines. labels Jul 4, 2023
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 4, 2023

It looks like quite a few integrations patch listen.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 4, 2023

Will save this one for the next long flight as it will be a bit of a grind to refactor the tests

Comment thread tests/components/ffmpeg/test_init.py
Comment thread tests/components/ffmpeg/test_init.py
@bdraco bdraco marked this pull request as ready for review July 4, 2023 20:27
@bdraco bdraco requested review from a team and mdegat01 as code owners July 4, 2023 20:27
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Jul 5, 2023
Comment thread tests/components/google_pubsub/test_init.py
Comment thread tests/components/influxdb/test_init.py Outdated
Comment thread tests/components/influxdb/test_init.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft July 5, 2023 14:11
@bdraco bdraco marked this pull request as ready for review July 5, 2023 14:46
@home-assistant home-assistant Bot requested a review from MartinHjelmare July 5, 2023 14:46
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 5, 2023

Thanks

@bdraco bdraco merged commit dc5ee71 into dev Jul 5, 2023
@bdraco bdraco deleted the slots_event_bus branch July 5, 2023 16:47
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants