Skip to content

Add slots to the StateMachine class#95849

Merged
MartinHjelmare merged 4 commits into
devfrom
sm_slots
Jul 5, 2023
Merged

Add slots to the StateMachine class#95849
MartinHjelmare merged 4 commits into
devfrom
sm_slots

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 4, 2023

Proposed change

Add slots to the StateMachine class

Fixes all tests to avoid patching the state machine.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed core small-pr PRs with less than 30 lines. labels Jul 4, 2023
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 4, 2023

We could do the same for the event bus if we can get rid of all the legacy tests that patch core

Comment thread homeassistant/components/recorder/core.py
@bdraco bdraco marked this pull request as ready for review July 4, 2023 15:42
@bdraco bdraco requested a review from a team as a code owner July 4, 2023 15:42
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 5, 2023
Comment thread homeassistant/core.py
class StateMachine:
"""Helper class that tracks the state of different entities."""

__slots__ = ("_states", "_reservations", "_bus", "_loop")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit with slots here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it's for memory, but slotted classes also have faster attribute lookups since they don't have the overhead of __dict__

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit b2e7088 into dev Jul 5, 2023
@MartinHjelmare MartinHjelmare deleted the sm_slots branch July 5, 2023 12:00
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 5, 2023

Thanks

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants