Skip to content

Revert "Remove airplay filter now that apple tv supports airplay 2"#95843

Merged
frenck merged 1 commit into
devfrom
revert-94693-airplay_filter
Jul 4, 2023
Merged

Revert "Remove airplay filter now that apple tv supports airplay 2"#95843
frenck merged 1 commit into
devfrom
revert-94693-airplay_filter

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jul 4, 2023

Reverts #94693

This is being reverted to get it out of the scope for the 2023.7 release.

Some of the issues/reasoning:

  • All Apple Airplay supported are discovered, even if we have (arguably) better native integrations available (Like Sonos, or Sony Bravia TVs).
  • macOS is being discovered (but not supported), this is being addressed in Abort apple_tv config flows when device is a Mac #95189, but not there yet.
  • The Apple TV integration is stepping out of its TV boundaries. The discussion is: Should we do that? Or, should Apple TV only work with Apple TV devices and should we investigate the possibility of creating a specific AirPlay integration instead?

fixes #95759

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 4, 2023

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apple_tv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apple_tv Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck merged commit 52d57ef into dev Jul 4, 2023
@frenck frenck deleted the revert-94693-airplay_filter branch July 4, 2023 12:41
@codyc1515
Copy link
Copy Markdown
Contributor

The Apple TV integration supports HomePods with no issues but it's not clear that they are supported, I.e. no virtual integration for HomePod.

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jul 5, 2023

@codyc1515 We are aware of that, that is not the reason for this revert. Please see the PR description and #95189 for more information and context.

../Frenck

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sonos devices discovered as "Apple TV"

3 participants