Skip to content

Disable proximity no platform log#95838

Merged
frenck merged 1 commit into
devfrom
disable-proximity-no-platform-log
Jul 4, 2023
Merged

Disable proximity no platform log#95838
frenck merged 1 commit into
devfrom
disable-proximity-no-platform-log

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Jul 4, 2023

Breaking change

Proposed change

  • Disable the no platform log warning for the proximity entity.
  • This entity and integration is very old and doesn't follow our current standards. We can't remove it without a breaking change though. So for now just disable the log.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MartinHjelmare 👍

../Frenck

@frenck frenck merged commit 9108739 into dev Jul 4, 2023
@frenck frenck deleted the disable-proximity-no-platform-log branch July 4, 2023 10:52
frenck pushed a commit that referenced this pull request Jul 5, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants