Update tuya vacuum supported features

[emontnemery]

Proposed change

Update tuya vacuum supported features

Background:

• VacuumEntityFeature.STATUS is meant only for the deprecated vacuum base class VacuumEntity, not for the base class StateVaccuumEntity which tuya's state vacuum platform is derived from.
• VacuumEntityFeature.STATE should be set for a vacuum platform derived from StateVaccuumEntity

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[frenck]

VacuumEntityFeature.STATE should be set for a vacuum platform derived from StateVaccuumEntity

This makes no sense to me. That state is optional from the platform upstream. And if I need to set it... why would it even be a flag to begin with?

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[emontnemery]

VacuumEntityFeature.STATE should be set for a vacuum platform derived from StateVaccuumEntity

This makes no sense to me. That state is optional from the platform upstream. And if I need to set it... why would it even be a flag to begin with?

I agree it does not make much sense.

It's legacy from the PR introducing the StateVacuumEntity in the first place: #15573; this is how the user, i.e. frontend or a script or automation calling a vacuum service knows if the entity implements VaccuumEntity or StateVaccuumEntity.
In particular, the service to call to pause a vacuum differs.

I think the way forward is to:

• Deprecate the VacuumEntity, scheduling it for removal in Q1 2024
• Once VacuumEntity has been removed, remove VacuumEntityFeature.STATE

[frenck]

Clear. Thanks 👍

../Frenck