Skip to content

Reolink fix missing title_placeholders#95827

Merged
frenck merged 3 commits into
home-assistant:devfrom
starkillerOG:reolink_reauth
Jul 4, 2023
Merged

Reolink fix missing title_placeholders#95827
frenck merged 3 commits into
home-assistant:devfrom
starkillerOG:reolink_reauth

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Fix missing title_placeholders in the re-auth flow of the reolink integration.
See #95760

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit b3e1a3f into home-assistant:dev Jul 4, 2023
frenck pushed a commit that referenced this pull request Jul 5, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrations - Discovered, Error.

2 participants