Skip to content

Remove the weak ref for tracking update listeners#95798

Merged
bdraco merged 1 commit into
devfrom
config-entry-update-weakref
Jul 3, 2023
Merged

Remove the weak ref for tracking update listeners#95798
bdraco merged 1 commit into
devfrom
config-entry-update-weakref

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jul 3, 2023

Breaking change

Proposed change

This removes the weakref for tracking update listeners. All update listeners return unsubscribe functions and can be automatically removed when a config entry is unloaded using entry.async_on_unload

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob requested a review from a team as a code owner July 3, 2023 18:13
@home-assistant home-assistant Bot added cla-signed core small-pr PRs with less than 30 lines. labels Jul 3, 2023
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jul 3, 2023

Testing on production..

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reloaded a few integrations with listeners, modified some config entries, all good

@bdraco bdraco merged commit 0f725a2 into dev Jul 3, 2023
@bdraco bdraco deleted the config-entry-update-weakref branch July 3, 2023 18:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants