Skip to content

Set Matter battery sensors as diagnostic#95794

Merged
MartinHjelmare merged 5 commits into
devfrom
matter-battery-diagnostic
Jul 4, 2023
Merged

Set Matter battery sensors as diagnostic#95794
MartinHjelmare merged 5 commits into
devfrom
matter-battery-diagnostic

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

Breaking change

Proposed change

  • Set matter battery sensors as diagnostic.
  • Add tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.



@pytest.fixture(name="door_lock")
async def door_lock_fixture(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this fixture as it can be used for more tests than the lock tests.

def binary_sensor_platform():
"""Load only the binary sensor platform."""
with patch(
"homeassistant.components.matter.discovery.DISCOVERY_SCHEMAS",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to patch this to make sure the event callback is for the binary sensor entity as the lock fixture creates more than one entity otherwise.

@marcelveldt
Copy link
Copy Markdown
Member

Didn't we have the eve door sensor already in the fixtures ?

@MartinHjelmare
Copy link
Copy Markdown
Member Author

Didn't we have the eve door sensor already in the fixtures ?

I didn't find it. I'll doublecheck.

@marcelveldt
Copy link
Copy Markdown
Member

Didn't we have the eve door sensor already in the fixtures ?

I didn't find it. I'll doublecheck.

No, you're right. I created a mock dump for the contact-sensor back then so maybe just replace that with the real dump now

Comment thread tests/components/matter/fixtures/nodes/eve-contact-sensor.json
@MartinHjelmare MartinHjelmare marked this pull request as draft July 3, 2023 17:32
@MartinHjelmare MartinHjelmare marked this pull request as ready for review July 4, 2023 11:15
Copy link
Copy Markdown
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@MartinHjelmare MartinHjelmare merged commit 02192dd into dev Jul 4, 2023
@MartinHjelmare MartinHjelmare deleted the matter-battery-diagnostic branch July 4, 2023 12:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants