Skip to content

Remove unsupported services from tuya vacuum#95790

Merged
frenck merged 1 commit into
devfrom
tuya_vacuum_tweak
Jul 3, 2023
Merged

Remove unsupported services from tuya vacuum#95790
frenck merged 1 commit into
devfrom
tuya_vacuum_tweak

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Jul 3, 2023

Proposed change

Remove the implementation of unsupported services vacuum.turn_on and vacuum.turn_off from tuya vacuum

Background:
Services vacuum.turn_on and vacuum.turn_off are supported by the deprecated base class VacuumEntity, not by the base class StateVacuumEntity which is implemented by tuya.

Note: Not marked as a breaking change because the PR was reverted after merging

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from frenck as a code owner July 3, 2023 16:30
@home-assistant home-assistant Bot added cla-signed integration: tuya small-pr PRs with less than 30 lines. labels Jul 3, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emontnemery 👍

../Frenck

@frenck frenck merged commit 5712d12 into dev Jul 3, 2023
@frenck frenck deleted the tuya_vacuum_tweak branch July 3, 2023 16:37
emontnemery added a commit that referenced this pull request Jul 4, 2023
emontnemery added a commit that referenced this pull request Jul 4, 2023
Revert "Remove unsupported services from tuya vacuum (#95790)"

This reverts commit 5712d12.
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants