Adjust services and properties supported by roborock vacuum#95789
Merged
Conversation
Contributor
|
Hey there @humbertogontijo, @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
20 tasks
Lash-L
approved these changes
Jul 4, 2023
ad6cbd0 to
8439bf6
Compare
Contributor
Author
|
PR rewritten to raise an issue instead of simply removing the service after some discussion with @MartinHjelmare on Discord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Deprecate the implementation of service
vacuum.start_pauseinroborockvacuum and adjust implemented propertiesBackground:
vacuum.start_pauseis supported by the deprecated base classVacuumEntity, not by the base classStateVacuumEntitywhich is implemented byroborock.statusis supported by the deprecated base classVacuumEntity, not by the base classStateVacuumEntitywhich is implemented byroborock.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: