Skip to content

Adjust services and properties supported by roborock vacuum#95789

Merged
MartinHjelmare merged 2 commits into
devfrom
roborock_vacuum_tweak
Jul 5, 2023
Merged

Adjust services and properties supported by roborock vacuum#95789
MartinHjelmare merged 2 commits into
devfrom
roborock_vacuum_tweak

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Jul 3, 2023

Proposed change

Deprecate the implementation of service vacuum.start_pause in roborock vacuum and adjust implemented properties

Background:

  • Service vacuum.start_pause is supported by the deprecated base class VacuumEntity, not by the base class StateVacuumEntity which is implemented by roborock.
  • Property status is supported by the deprecated base class VacuumEntity, not by the base class StateVacuumEntity which is implemented by roborock.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Hey there @humbertogontijo, @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery emontnemery force-pushed the roborock_vacuum_tweak branch from ad6cbd0 to 8439bf6 Compare July 4, 2023 12:13
@emontnemery emontnemery changed the title Remove unsupported services from roborock vacuum Adjust services supported by roborock vacuum Jul 4, 2023
@emontnemery emontnemery requested a review from Lash-L July 4, 2023 12:13
@emontnemery emontnemery changed the title Adjust services supported by roborock vacuum Adjust services and properties supported by roborock vacuum Jul 4, 2023
@emontnemery
Copy link
Copy Markdown
Contributor Author

PR rewritten to raise an issue instead of simply removing the service after some discussion with @MartinHjelmare on Discord

@emontnemery emontnemery marked this pull request as ready for review July 4, 2023 12:22
@emontnemery emontnemery added deprecation Indicates a breaking change to happen in the future and removed breaking-change labels Jul 4, 2023
Copy link
Copy Markdown
Contributor

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 5, 2023
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 39dcb5a into dev Jul 5, 2023
@MartinHjelmare MartinHjelmare deleted the roborock_vacuum_tweak branch July 5, 2023 10:53
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed deprecation Indicates a breaking change to happen in the future integration: roborock Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants