Tune httpx keep alives for polling integrations#95782
Merged
Merged
Conversation
aiohttp closes the connection after 15s by default, and httpx closes the connection after 5s by default. We have a lot of integrations that poll every 10-60s which create and tear down connections over and over. Set the keep alive time to 65s to maximize connection reuse and avoid tls negotiation overhead
Member
Author
|
Still testing with this, but I think we can go as low as 31s and still be good for 90% of the cases |
bdraco
commented
Jul 3, 2023
bdraco
commented
Jul 3, 2023
bdraco
commented
Jul 3, 2023
bdraco
commented
Jul 3, 2023
Member
Author
|
At 32 there is still a nice drop in connection churn and less risk of side effects from non-compliant webservers |
balloob
approved these changes
Jul 3, 2023
Member
balloob
left a comment
There was a problem hiding this comment.
Should we follow the 75s too like nginx has ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
aiohttp closes the connection after 15s by default, and httpx closes the connection after 5s by default.
We have a lot of integrations that poll every 10-30s which create and tear down connections over and over.
Set the keep alive time to 15s for httpx to match aiohttp to maximize connection reuse and avoid tls negotiation overhead
The server side default for nginx is 75s https://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_timeout which means we likely close a lot of connections that could be reused with the defaults
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: