Skip to content

Use common translations for On, Off, Open and Closed#95779

Merged
jbouwh merged 4 commits into
home-assistant:devfrom
jbouwh:common-translation-on-off
Jul 4, 2023
Merged

Use common translations for On, Off, Open and Closed#95779
jbouwh merged 4 commits into
home-assistant:devfrom
jbouwh:common-translation-on-off

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Jul 3, 2023

Proposed change

Use common translations for On, Off, Open and Closed.
This make maintaining translations easier.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/sensibo/strings.json Outdated
Kane610
Kane610 previously requested changes Jul 3, 2023
Comment thread homeassistant/components/deconz/strings.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft July 3, 2023 15:31
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@jbouwh jbouwh marked this pull request as ready for review July 3, 2023 15:32
@home-assistant home-assistant Bot requested a review from Kane610 July 3, 2023 15:32
Comment thread homeassistant/components/deconz/strings.json Outdated
@Kane610 Kane610 dismissed their stale review July 3, 2023 16:45

Didn't think it through

Comment thread homeassistant/components/zha/strings.json Outdated
Comment thread homeassistant/components/deconz/strings.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft July 3, 2023 17:55
@jbouwh jbouwh marked this pull request as ready for review July 4, 2023 09:50
@home-assistant home-assistant Bot requested a review from gjohansson-ST July 4, 2023 09:50
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 👍

../Frenck

Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jbouwh jbouwh merged commit c26dc09 into home-assistant:dev Jul 4, 2023
@jbouwh jbouwh deleted the common-translation-on-off branch July 4, 2023 11:52
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants