Skip to content

Fix siren.toggle service schema#95770

Merged
emontnemery merged 1 commit into
devfrom
siren_fix_toggle
Jul 4, 2023
Merged

Fix siren.toggle service schema#95770
emontnemery merged 1 commit into
devfrom
siren_fix_toggle

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Fix siren.toggle service schema so it requires the targeted siren to support both SirenEntityFeature.TURN_ON and SirenEntityFeature.TURN_OFF

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Hey there @home-assistant/core, @raman325, mind taking a look at this pull request as it has been labeled with an integration (siren) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of siren can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign siren Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Copy Markdown
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@emontnemery emontnemery merged commit e0c77fb into dev Jul 4, 2023
@emontnemery emontnemery deleted the siren_fix_toggle branch July 4, 2023 06:48
@MartinHjelmare
Copy link
Copy Markdown
Member

There was a failing siren test. Was that not a problem?

@emontnemery
Copy link
Copy Markdown
Contributor Author

There was a failing siren test. Was that not a problem?

That was indeed a problem, fixed here: #95825

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants