Skip to content

Address Opower review comments#95763

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
tronikos:opower_comments
Jul 3, 2023
Merged

Address Opower review comments#95763
MartinHjelmare merged 3 commits into
home-assistant:devfrom
tronikos:opower_comments

Conversation

@tronikos
Copy link
Copy Markdown
Member

@tronikos tronikos commented Jul 3, 2023

Breaking change

Proposed change

Address @MartinHjelmare 's comments from #90489

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/opower/sensor.py Outdated
Comment thread homeassistant/components/opower/sensor.py Outdated
Comment thread homeassistant/components/opower/sensor.py Outdated
Comment thread homeassistant/components/opower/sensor.py Outdated
Comment thread homeassistant/components/opower/sensor.py Outdated
Comment thread homeassistant/components/opower/sensor.py Outdated
Comment thread homeassistant/components/opower/sensor.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft July 3, 2023 12:13
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

tronikos and others added 2 commits July 3, 2023 05:32
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@tronikos tronikos marked this pull request as ready for review July 3, 2023 12:33
@home-assistant home-assistant Bot requested a review from MartinHjelmare July 3, 2023 12:33
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Opower: Address review comments Address Opower review comments Jul 3, 2023
@MartinHjelmare MartinHjelmare merged commit 4e7d8b5 into home-assistant:dev Jul 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants