Skip to content

Use a normal tuple for the EventBus jobs#95731

Merged
bdraco merged 1 commit into
devfrom
filterable_job_refactor
Jul 2, 2023
Merged

Use a normal tuple for the EventBus jobs#95731
bdraco merged 1 commit into
devfrom
filterable_job_refactor

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 2, 2023

Proposed change

We never access the names on the namedtuple so there is no longer a need to use one. The namedtuple unpacking had more overhead than setting up the job for execution (~58% of the run time of async_set & children currently, at minimum <~27% after switching). async_set/async_fire is one of the most called paths in HA and any latency here is felt throughout the whole system.

This one was a bit surprising, and I only found it because I was looking at improving startup stability when the event loop gets too far behind following some comments made from creators about lots of integrations retrying/failing to set up at startup.

Screenshot_2023-07-02_at_3_25_05_PM Screenshot_2023-07-02_at_3_24_58_PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We never access the names on the NamedTuple so there
is no longer a need to use one. The namedtuple unpacking
had more overhead than setting up the job for execution
@home-assistant home-assistant Bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Jul 2, 2023
@bdraco bdraco marked this pull request as ready for review July 2, 2023 20:48
@bdraco bdraco requested a review from a team as a code owner July 2, 2023 20:48
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 2, 2023

thanks

@bdraco bdraco merged commit 0ff3836 into dev Jul 2, 2023
@bdraco bdraco deleted the filterable_job_refactor branch July 2, 2023 21:35
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants