Use a normal tuple for the EventBus jobs#95731
Merged
Merged
Conversation
We never access the names on the NamedTuple so there is no longer a need to use one. The namedtuple unpacking had more overhead than setting up the job for execution
MartinHjelmare
approved these changes
Jul 2, 2023
Member
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
We never access the names on the
namedtupleso there is no longer a need to use one. Thenamedtupleunpacking had more overhead than setting up the job for execution (~58% of the run time ofasync_set& children currently, at minimum <~27% after switching).async_set/async_fireis one of the most called paths in HA and any latency here is felt throughout the whole system.This one was a bit surprising, and I only found it because I was looking at improving startup stability when the event loop gets too far behind following some comments made from creators about lots of integrations retrying/failing to set up at startup.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: