Skip to content

Quality improvement on LOQED integration#95725

Merged
balloob merged 1 commit into
home-assistant:devfrom
mikewoudenberg:loqed-integration
Jul 3, 2023
Merged

Quality improvement on LOQED integration#95725
balloob merged 1 commit into
home-assistant:devfrom
mikewoudenberg:loqed-integration

Conversation

@mikewoudenberg
Copy link
Copy Markdown
Contributor

Raise error correctly
Remove obsolete consts
Remove callback, hass assignment and info log
Use name from LOQED API instead of default name
Correct entity name for assertion

Proposed change

Fixes review comments raised in #70080 after it being merged

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Raise error correctly
Remove obsolete consts
Remove callback, hass assignment and info log
Use name from LOQED API instead of default name
Correct entity name for assertion
@balloob balloob merged commit ab50069 into home-assistant:dev Jul 3, 2023
@frenck frenck added this to the 2023.7.0 milestone Jul 3, 2023
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 3, 2023

Tagged this one for the beta, as this is a new integration landing this version.

balloob pushed a commit that referenced this pull request Jul 3, 2023
Remove generated translation
Raise error correctly
Remove obsolete consts
Remove callback, hass assignment and info log
Use name from LOQED API instead of default name
Correct entity name for assertion
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants