Skip to content

Small improvements to websocket api performance#95693

Merged
bdraco merged 1 commit into
devfrom
websocket
Jul 2, 2023
Merged

Small improvements to websocket api performance#95693
bdraco merged 1 commit into
devfrom
websocket

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 2, 2023

Proposed change

Small improvements to websocket api performance

These are all the changes from my integration branch that I have been running for a while.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 2, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (websocket_api) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of websocket_api can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign websocket_api Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 2, 2023

Need to dig out the aiohttp router optimizations as well. Currently finding a router does a linear search which is starting to be a problem as we add more paths

@bdraco bdraco marked this pull request as ready for review July 2, 2023 17:18
@bdraco bdraco requested a review from a team as a code owner July 2, 2023 17:18
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @bdraco 👍

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 2, 2023

Thanks

@bdraco bdraco merged commit 2aff138 into dev Jul 2, 2023
@bdraco bdraco deleted the websocket branch July 2, 2023 17:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants