Skip to content

Remove obsolete entity name from Lametric#95688

Merged
gjohansson-ST merged 1 commit into
home-assistant:devfrom
joostlek:lametric_entity_translations
Jul 2, 2023
Merged

Remove obsolete entity name from Lametric#95688
gjohansson-ST merged 1 commit into
home-assistant:devfrom
joostlek:lametric_entity_translations

Conversation

@joostlek
Copy link
Copy Markdown
Member

@joostlek joostlek commented Jul 1, 2023

Proposed change

This field is already being translated, so the name is not needed anymore.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 1, 2023

Hey there @robbiet480, @frenck, @bachya, mind taking a look at this pull request as it has been labeled with an integration (lametric) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lametric can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lametric Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST gjohansson-ST merged commit 23a1666 into home-assistant:dev Jul 2, 2023
@joostlek joostlek deleted the lametric_entity_translations branch July 2, 2023 17:30
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 3, 2023

@joostlek @robbiet480 @gjohansson-ST This sensor has no device class? How would removing this work here? Is is now a nameless sensor, this seems wrong?

../Frenck

@joostlek
Copy link
Copy Markdown
Member Author

joostlek commented Jul 3, 2023

@joostlek @robbiet480 @gjohansson-ST This sensor has no device class? How would removing this work here? Is is now a nameless sensor, this seems wrong?

../Frenck

This sensor had both a translation key and a name. The super entity has has_entity_name = True so removing the name it would use the translation key

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 3, 2023

Oh right! 🤦 Sorry for the noise.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants