Skip to content

Fix implicit device name for SimpliSafe locks#95681

Merged
joostlek merged 1 commit into
home-assistant:devfrom
bachya:ss-implicit-device-name-for-lock
Jul 1, 2023
Merged

Fix implicit device name for SimpliSafe locks#95681
joostlek merged 1 commit into
home-assistant:devfrom
bachya:ss-implicit-device-name-for-lock

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Jul 1, 2023

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joostlek joostlek merged commit cac6dc0 into home-assistant:dev Jul 1, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 2, 2023
@bachya bachya deleted the ss-implicit-device-name-for-lock branch July 2, 2023 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid device name for SimpliSafe in 2023.07 beta

3 participants