Bump pydaikin 2.10.5 by mover85 · Pull Request #95656 · home-assistant/core

mover85 · 2023-07-01T05:05:06Z

Proposed change

Bump Daikin version, changelog: https://bitbucket.org/mustang51/pydaikin/branches/compare/v2.10.5%0Dv2.9.0

Add zone temperature control.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Daikin breaking changes - renaming devices #94046, Unable to toggle Daikin switches #94648 and Daikin service climate.turn_on not working #94372

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2023-07-01T05:05:13Z

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.

fredrike

LGTM

The unique id migration is missing tests

bdraco · 2023-07-03T03:38:23Z

Just realized there are no tests for the unique id migration. We should have at least a basic test for this as these tend to be hard to fix later if something goes wrong

bdraco

Nice! Looks like there is a stale docstring to fix

bdraco · 2023-07-04T14:19:50Z

Looks good 👍

It would be nice to cover that one line before merging

mover85 · 2023-07-05T02:17:12Z

It would be nice to cover that one line before merging

I'm not sure if I can cover that line, should I unnest the function to allow testing?

home-assistant · 2023-07-05T09:43:06Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

MartinHjelmare

Looks good!

bdraco

Thanks @mover85 for improving the integration 🎉

jypsilantis · 2023-07-06T08:23:44Z

Just wondering if this made it into Core 2023.7.0. I just tried and the 4/3 parameter issue is still there. Happy to assist with logs etc if anyone needs them.

MartinHjelmare · 2023-07-06T08:30:12Z

No this wasn't tagged for the release.

@mover85 @fredrike is this safe to go in a patch release?

mover85 · 2023-07-07T02:39:18Z

@mover85 @fredrike is this safe to go in a patch release?

Yes

MartinHjelmare · 2023-07-07T06:39:15Z

I've tagged the PR for the next patch release.

mover85 added 2 commits July 1, 2023 04:29

Bump pydaikin to 2.10.5

0824e7f

Added migration for daikin

5050e46

home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: daikin Quality Scale: platinum labels Jul 1, 2023

fredrike approved these changes Jul 1, 2023

View reviewed changes

home-assistant Bot added the code-owner-approved label Jul 1, 2023

Merge branch 'dev' into update-pydaikin

8d51765

bdraco previously approved these changes Jul 3, 2023

View reviewed changes

bdraco modified the milestone: 2023.7.0 Jul 3, 2023

Add tests for migration

4d7c1cf

mover85 requested a review from bdraco July 4, 2023 02:20

Fix migration test

b0d36fa

bdraco reviewed Jul 4, 2023

View reviewed changes

Comment thread tests/components/daikin/test_init.py Outdated

bdraco reviewed Jul 4, 2023

View reviewed changes

Comment thread tests/components/daikin/test_init.py

Mock pydaikin

6cdc531

mover85 requested a review from bdraco July 4, 2023 11:23

bdraco reviewed Jul 4, 2023

View reviewed changes

Comment thread tests/components/daikin/test_init.py Outdated

Fix stale comment

9a19b08

bdraco approved these changes Jul 4, 2023

View reviewed changes

mover85 added 2 commits July 5, 2023 02:42

Add more tests for daikin

7baf11d

Refactor init for testing

d67ce78

frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 5, 2023

MartinHjelmare requested changes Jul 5, 2023

View reviewed changes

Comment thread homeassistant/components/daikin/__init__.py Outdated

Comment thread homeassistant/components/daikin/__init__.py Outdated

Comment thread homeassistant/components/daikin/__init__.py Outdated

Comment thread homeassistant/components/daikin/__init__.py Outdated

home-assistant Bot marked this pull request as draft July 5, 2023 09:43

Fix logging and rework migration

d1606df

mover85 marked this pull request as ready for review July 5, 2023 10:57

home-assistant Bot requested a review from MartinHjelmare July 5, 2023 10:57

Update new name value

7663d1d

MartinHjelmare approved these changes Jul 5, 2023

View reviewed changes

bdraco approved these changes Jul 5, 2023

View reviewed changes

bdraco merged commit f028d1a into home-assistant:dev Jul 5, 2023

joostlek pushed a commit to joostlek/core that referenced this pull request Jul 6, 2023

Bump pydaikin 2.10.5 (home-assistant#95656)

322b489

yesterdayshero mentioned this pull request Jul 6, 2023

Unable to toggle Daikin switches #94648

Closed

MartinHjelmare added this to the 2023.7.2 milestone Jul 7, 2023

github-actions Bot locked and limited conversation to collaborators Jul 8, 2023

balloob added the cherry-picked label Jul 13, 2023

Uh oh!

Conversation

mover85 commented Jul 1, 2023

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Jul 1, 2023

Uh oh!

fredrike left a comment

Choose a reason for hiding this comment

Uh oh!

bdraco commented Jul 3, 2023

Uh oh!

Uh oh!

Uh oh!

bdraco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bdraco commented Jul 4, 2023

Uh oh!

mover85 commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

home-assistant Bot commented Jul 5, 2023

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

bdraco left a comment

Choose a reason for hiding this comment

Uh oh!

jypsilantis commented Jul 6, 2023

Uh oh!

MartinHjelmare commented Jul 6, 2023

Uh oh!

mover85 commented Jul 7, 2023

Uh oh!

MartinHjelmare commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mover85 commented Jul 5, 2023 •

edited

Loading