Skip to content

Add mold risk sensor to Notion#95643

Merged
bachya merged 1 commit into
home-assistant:devfrom
bachya:notion-mold
Jul 2, 2023
Merged

Add mold risk sensor to Notion#95643
bachya merged 1 commit into
home-assistant:devfrom
bachya:notion-mold

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Jun 30, 2023

Proposed change

CleanShot 2023-06-30 at 13 09 24

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Jun 30, 2023
@bachya bachya changed the title Add mold detection sensor to Notion Add mold risk sensor to Notion Jun 30, 2023
Copy link
Copy Markdown
Contributor

@guix77 guix77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Jul 2, 2023

Thanks!

@bachya bachya merged commit c1b8e4a into home-assistant:dev Jul 2, 2023
@bachya bachya deleted the notion-mold branch July 2, 2023 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants