Skip to content

Add unique_id to Wirelesstag entities.#95631

Merged
balloob merged 4 commits into
home-assistant:devfrom
davecpearce:wirelesstag_unique_id
Jun 30, 2023
Merged

Add unique_id to Wirelesstag entities.#95631
balloob merged 4 commits into
home-assistant:devfrom
davecpearce:wirelesstag_unique_id

Conversation

@davecpearce
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Add unique_id's to the entities for the Wirelesstag component to support entity configurations from the UI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @sergeymaysak, mind taking a look at this pull request as it has been labeled with an integration (wirelesstag) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wirelesstag can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wirelesstag Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Comment thread homeassistant/components/wirelesstag/binary_sensor.py Outdated
Comment thread homeassistant/components/wirelesstag/sensor.py Outdated
Comment thread homeassistant/components/wirelesstag/switch.py Outdated
davecpearce and others added 3 commits June 30, 2023 14:51
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@balloob balloob merged commit 982a52b into home-assistant:dev Jun 30, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2023
@davecpearce davecpearce deleted the wirelesstag_unique_id branch November 21, 2023 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants