Skip to content

Fix device source for Riemann sum integral#95622

Merged
balloob merged 1 commit into
home-assistant:devfrom
dougiteixeira:fix-device-source-integration
Jun 30, 2023
Merged

Fix device source for Riemann sum integral#95622
balloob merged 1 commit into
home-assistant:devfrom
dougiteixeira:fix-device-source-integration

Conversation

@dougiteixeira
Copy link
Copy Markdown
Contributor

@dougiteixeira dougiteixeira commented Jun 30, 2023

Breaking change

None

Proposed change

Fix device source for Riemann sum integral.

Some integrations may not use identifiers in device registry.

The connections propriety has been included.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of integration can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign integration Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dougiteixeira
Copy link
Copy Markdown
Contributor Author

This PR needs to be included in the next release because PR #94727 has been included in the beta.

@dougiteixeira dougiteixeira changed the title Fix device source for Integration Fix device source for Riemann sum integral Jun 30, 2023
@balloob balloob added this to the 2023.7.0 milestone Jun 30, 2023
@balloob balloob merged commit c6210b6 into home-assistant:dev Jun 30, 2023
@dougiteixeira dougiteixeira deleted the fix-device-source-integration branch June 30, 2023 18:54
balloob pushed a commit that referenced this pull request Jun 30, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants