Skip to content

Fix Diagnostics in Advantage Air#95608

Merged
balloob merged 6 commits into
home-assistant:devfrom
Bre77:aa-diagissue
Jun 30, 2023
Merged

Fix Diagnostics in Advantage Air#95608
balloob merged 6 commits into
home-assistant:devfrom
Bre77:aa-diagissue

Conversation

@Bre77
Copy link
Copy Markdown
Contributor

@Bre77 Bre77 commented Jun 30, 2023 •
edited
Loading

Proposed change

The diagnostics broke after the AdvantageAirData dataclass was introduced. I'm taking this chance to also redact some more fields, add some more data from newer features, and add a basic test.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Bre77 Bre77 changed the title Aa diagissue Fix Diagnostics in Advantage Air Jun 30, 2023
@gjohansson-ST
Copy link
Copy Markdown
Member

gjohansson-ST commented Jun 30, 2023

Please provide an example output in the PR description

@gjohansson-ST gjohansson-ST added this to the 2023.7.0 milestone Jun 30, 2023
balloob
balloob reviewed Jun 30, 2023
View reviewed changes
Comment thread tests/components/advantage_air/test_diagnostics.py Outdated
balloob
balloob reviewed Jun 30, 2023
View reviewed changes
Comment thread tests/components/advantage_air/test_diagnostics.py
@balloob balloob merged commit d4e40ed into home-assistant:dev Jun 30, 2023
balloob added a commit that referenced this pull request Jun 30, 2023
@Bre77 @balloob
Fix Diagnostics in Advantage Air (#95608)
73cb17c 
* Fix diag paths

* Fix key sand add redactions

* Name things better.

* Add super basic test

* Rename docstring

* Add snapshot

---------

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed integration: advantage_air Quality Scale: platinum small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2023.7.0

Development

Successfully merging this pull request may close these issues.

Download Diagnostics fails with error

3 participants

@Bre77 @gjohansson-ST @balloob