Skip to content

Add Airzone Cloud Zone running binary sensor#95606

Merged
bdraco merged 1 commit into
home-assistant:devfrom
Noltari:airzone-cloud-binary-sensors-zone-running
Jul 4, 2023
Merged

Add Airzone Cloud Zone running binary sensor#95606
bdraco merged 1 commit into
home-assistant:devfrom
Noltari:airzone-cloud-binary-sensors-zone-running

Conversation

@Noltari
Copy link
Copy Markdown
Contributor

@Noltari Noltari commented Jun 30, 2023

Proposed change

Add running binary sensor support to Airzone Cloud zones, which indicates whether the HVAC is on or off for each Airzone Zone.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari changed the title airzone_cloud: binary_sensor: zone: add running Add Airzone Cloud zone running binary sensor Jun 30, 2023
@Noltari Noltari changed the title Add Airzone Cloud zone running binary sensor Add Airzone Cloud Zone running binary sensor Jun 30, 2023
Copy link
Copy Markdown
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the change looks good to me. It would be helpful if the PR description could provide a bit more of an explanation as to why this is needed and what the user benefit will be.

@home-assistant home-assistant Bot marked this pull request as draft July 4, 2023 06:24
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Jul 4, 2023

The content of the change looks good to me. It would be helpful if the PR description could provide a bit more of an explanation as to why this is needed and what the user benefit will be.

Thanks, I added a bit more description which hopefully makes it more clear for everyone.

@Noltari Noltari marked this pull request as ready for review July 4, 2023 07:43
@home-assistant home-assistant Bot requested a review from davet2001 July 4, 2023 07:43
Copy link
Copy Markdown
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @Noltari 😀

@bdraco bdraco merged commit 60e2ee8 into home-assistant:dev Jul 4, 2023
@Noltari Noltari deleted the airzone-cloud-binary-sensors-zone-running branch July 4, 2023 20:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants