Skip to content

Fix device source for Utility Meter#95585

Merged
balloob merged 2 commits into
home-assistant:devfrom
dougiteixeira:fix-device-source-utility_meter
Jun 30, 2023
Merged

Fix device source for Utility Meter#95585
balloob merged 2 commits into
home-assistant:devfrom
dougiteixeira:fix-device-source-utility_meter

Conversation

@dougiteixeira
Copy link
Copy Markdown
Contributor

@dougiteixeira dougiteixeira commented Jun 29, 2023

Breaking change

None

Proposed change

Fix device source for Utility Meter.

Some integrations may not use identifiers in device registry.

The connections propriety has been included, for ESPHome it is enough, but should we include other?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (utility_meter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of utility_meter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign utility_meter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dougiteixeira
Copy link
Copy Markdown
Contributor Author

When the solution is defined in this PR, I will implement it in the other helpers.

@dougiteixeira dougiteixeira marked this pull request as ready for review June 29, 2023 23:06
@balloob balloob added this to the 2023.7.0 milestone Jun 30, 2023
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be enough. We don’t match on other properties.

@balloob balloob merged commit f2f0c38 into home-assistant:dev Jun 30, 2023
balloob pushed a commit that referenced this pull request Jun 30, 2023
* Fix Device Source

* Remove debug
@dougiteixeira dougiteixeira deleted the fix-device-source-utility_meter branch June 30, 2023 03:33
@dougiteixeira dougiteixeira restored the fix-device-source-utility_meter branch June 30, 2023 03:33
@dougiteixeira dougiteixeira deleted the fix-device-source-utility_meter branch June 30, 2023 03:33
@dougiteixeira dougiteixeira restored the fix-device-source-utility_meter branch June 30, 2023 03:33
@dougiteixeira dougiteixeira deleted the fix-device-source-utility_meter branch June 30, 2023 03:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utility meter sensor not displayed in source device

3 participants