Skip to content

Fix missing EntityDescription names in Overkiz #95583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Jul 1, 2023
Merged

Fix missing EntityDescription names in Overkiz #95583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fe6f33
Fix labels
iMicknl Jun 29, 2023
d71dc6e
Update homeassistant/components/overkiz/entity.py
balloob Jun 30, 2023
86bef0f
Check if description.name is string
iMicknl Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions homeassistant/components/overkiz/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,5 @@ def __init__(
# In case of sub device, use the provided label
# and append the name of the type of entity
self._attr_name = f"{self.device.label} {description.name}"
elif isinstance(description.name, str):
self._attr_name = description.name

@balloob balloob Jun 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casting something to string meant that both None and UndefinedType (if no name was set) got turned into a string. I removed that statement and now type checking is correctly complaining.

It is better to just set name=None in the entity descriptions that need it.

@iMicknl iMicknl Jun 30, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to have a better look here... Setting name to None in entity description won't work, because we actually want to use the name from the entity description.

There are other cases where we want to inherit the name from the device name, for example for cover entities. Since a recent change in core, it will print an error when we implicit inherit the name from the device. Looking at this at a first glance, it will require more changes to explicit set the name.

@iMicknl iMicknl Jun 30, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a fix for now. However I should have a better look in the coming days (or shortly after the next release), to see if we can rewrite the OverkizEntity.