Skip to content

Update log message when referenced entity not found #95577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 3 commits into from
Jul 1, 2023
Merged

Update log message when referenced entity not found #95577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f13f3
Update log message when referenced entity not found
balloob Jun 29, 2023
7b50638
Update homeassistant/helpers/service.py
balloob Jun 30, 2023
3875953
Update test
balloob Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/helpers/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def log_missing(self, missing_entities: set[str]) -> None:
return

_LOGGER.warning(
"Unable to find referenced %s or it is/they are currently not available",
"Referenced %s are missing or not currently available",
", ".join(parts),
)

Expand Down
12 changes: 6 additions & 6 deletions tests/helpers/test_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,9 +1238,9 @@ async def test_entity_service_call_warn_referenced(
)
await service.entity_service_call(hass, {}, "", call)
assert (
"Unable to find referenced areas non-existent-area, devices"
" non-existent-device, entities non.existent" in caplog.text
)
"Referenced areas non-existent-area, devices non-existent-device, "
"entities non.existent are missing or not currently available"
) in caplog.text


async def test_async_extract_entities_warn_referenced(
Expand All @@ -1259,9 +1259,9 @@ async def test_async_extract_entities_warn_referenced(
extracted = await service.async_extract_entities(hass, {}, call)
assert len(extracted) == 0
assert (
"Unable to find referenced areas non-existent-area, devices"
" non-existent-device, entities non.existent" in caplog.text
)
"Referenced areas non-existent-area, devices non-existent-device, "
"entities non.existent are missing or not currently available"
) in caplog.text


async def test_async_extract_config_entry_ids(hass: HomeAssistant) -> None:
Expand Down