Skip to content

Fix entity name for iBeacon and Roku#95574

Merged
balloob merged 2 commits into
devfrom
entity-name-ibeacon-roku
Jun 29, 2023
Merged

Fix entity name for iBeacon and Roku#95574
balloob merged 2 commits into
devfrom
entity-name-ibeacon-roku

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jun 29, 2023

Breaking change

Proposed change

Add entity name = None for entities that need device name

Fixes #95561
Fixes #95556

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration (roku) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roku can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roku Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (ibeacon) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ibeacon can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ibeacon Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@balloob balloob changed the title Fix entity nmae for iBeacon and Roku Fix entity name for iBeacon and Roku Jun 29, 2023
@balloob balloob merged commit decb1a3 into dev Jun 29, 2023
@balloob balloob deleted the entity-name-ibeacon-roku branch June 29, 2023 17:43
balloob added a commit that referenced this pull request Jun 29, 2023
* Fix entity nmae for iBeacon and Roku

* Roku remote too
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

3 participants