Add explicit device name to Broadlink

[joostlek]

Proposed change

Add explicit device name to Broadlink. Apparently every instance of Broadlink entity has _attr_has_entity_name = True. So moved it to the superclass.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes BroadlinkRemote - is implicitly using device name by not setting its name. Instead, the name should be set to None #95514
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Danielhiversen, @felipediel, @L-I-Am, mind taking a look at this pull request as it has been labeled with an integration (broadlink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of broadlink can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign broadlink Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[felipediel]

Hi. Thanks for the contribution! A quick review... BroadlinkRMSwitch doesn't have _attr_has_entity_name = True.

[joostlek]

Hi. Thanks for the contribution! A quick review... BroadlinkRMSwitch doesn't have _attr_has_entity_name = True.

You mean shouldn't have? I wasn't completely sure this last change was good (but my laptop was empty so now I'm in the office and I checked it), so I now reverted this change. How come that switch doesnt have that?

[felipediel]

They are configured via YAML. We still need to create a flow to configure them via interface, so they are a bit different from other entities.

[joostlek]

They are configured via YAML. We still need to create a flow to configure them via interface, so they are a bit different from other entities.

Aah check, for now this change will solve the issue then.

[frenck]

Thanks, @joostlek 👍

../Frenck