Skip to content

Remove statement in iss config flow#95472

Merged
balloob merged 1 commit into
home-assistant:devfrom
joostlek:iss_default_name
Jun 29, 2023
Merged

Remove statement in iss config flow#95472
balloob merged 1 commit into
home-assistant:devfrom
joostlek:iss_default_name

Conversation

@joostlek
Copy link
Copy Markdown
Member

Proposed change

The form the user gets doesnt have any input, so user_input[CONF_NAME] is always none. In git history I see that back in the yaml days it was possible to give custom names, but the functionality wouldnt change if you have 2 sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @DurgNomis-drol, mind taking a look at this pull request as it has been labeled with an integration (iss) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of iss can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign iss Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@balloob balloob merged commit b0c0b58 into home-assistant:dev Jun 29, 2023
@joostlek joostlek deleted the iss_default_name branch June 29, 2023 05:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants