Remove polling_interval_seconds option from wemo#95468
Conversation
|
Hi @marcelveldt please take a look when you get a chance. Note: My availability is limited today. I'll try to respond to any feedback, but it's a travel day for me, so it may be several hours before I can respond. |
|
Thanks for the very quick turnaround, appreciated! I just remembered in your previous PR you mentioned you got some complaints about databases growing too fast due to too many state updates. A solid way to fix that could be to implement "significant_change" logic where you tell the HA recorder what data change is considered significant enough. Maybe also worth taking a look at ? https://developers.home-assistant.io/docs/core/platform/significant_change |
marcelveldt
left a comment
There was a problem hiding this comment.
don't forget to update docs PR.
Thanks!
|
Thanks for the reminder. home-assistant/home-assistant.io#28001 is the docs update.
Yes, good call. I'll send another PR to add significant_change logic. It's okay if this isn't in the 2023.7.0 release though, correct? |
Yes that is correct. It was just a tip after remembering you reported that issue. |
|
Clearing milestone as it was merged before beta cut. |
Proposed change
Remove the
polling_interval_secondsoption added in #56972 based on feedback after that PR was merged. Users can disable automatic polling and set up their own polling interval if needed.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: