Skip to content

Add config flow for zodiac#95447

Merged
MartinHjelmare merged 4 commits into
home-assistant:devfrom
joostlek:zodiac_config_flow
Jun 30, 2023
Merged

Add config flow for zodiac#95447
MartinHjelmare merged 4 commits into
home-assistant:devfrom
joostlek:zodiac_config_flow

Conversation

@joostlek
Copy link
Copy Markdown
Member

@joostlek joostlek commented Jun 28, 2023

Breaking change

Add config flow for zodiac. Imports current configuration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: zodiac new-feature Quality Scale: silver labels Jun 28, 2023
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @JulienTant, mind taking a look at this pull request as it has been labeled with an integration (zodiac) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zodiac can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zodiac Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Comment thread homeassistant/components/zodiac/__init__.py
Comment thread homeassistant/components/zodiac/sensor.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft June 29, 2023 14:54
@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Jun 29, 2023

Please fill out the whole PR template.

@joostlek joostlek marked this pull request as ready for review June 29, 2023 20:02
@home-assistant home-assistant Bot requested a review from MartinHjelmare June 29, 2023 20:02
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 4ac92d7 into home-assistant:dev Jun 30, 2023
@joostlek joostlek deleted the zodiac_config_flow branch June 30, 2023 11:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: zodiac new-feature Quality Scale: silver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants