Add entity translations to Growatt Server#95410
Merged
jbouwh merged 2 commits intoJun 28, 2023
Merged
Conversation
Contributor
|
Hey there @muppet3000, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
frenck
added
the
smash
jbouwh
requested changes
Jun 28, 2023
Comment on lines
62
to
63
| translation_key="mix_solar_generation_lifetime", | ||
| name="Lifetime solar energy", |
Contributor
There was a problem hiding this comment.
Did you miss removing name here?
Contributor
There was a problem hiding this comment.
Other than this suggested change I'm happy with the rest of it.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
frenck
removed
the
smash
jbouwh
approved these changes
Jun 28, 2023
jbouwh
added
the
smash
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add entity translations to Growatt Server
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: