Skip to content

Fix sending a (default) pincode to Matter Lock operations #95402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 2 commits into from
Jun 27, 2023
Merged

Fix sending a (default) pincode to Matter Lock operations #95402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd8d05
Support sending a pincode to lock/unlock operations
marcelveldt Jun 27, 2023
7212a48
Update lock.py
marcelveldt Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions homeassistant/components/matter/lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from homeassistant.components.lock import LockEntity, LockEntityDescription
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import Platform
from homeassistant.const import ATTR_CODE, Platform
from homeassistant.core import HomeAssistant, callback
from homeassistant.helpers.entity_platform import AddEntitiesCallback

Expand Down Expand Up @@ -56,11 +56,25 @@ async def send_device_command(

async def async_lock(self, **kwargs: Any) -> None:
"""Lock the lock with pin if needed."""
await self.send_device_command(command=clusters.DoorLock.Commands.LockDoor())
code: str = kwargs.get(
ATTR_CODE,
self._lock_option_default_code,
)
code_bytes = code.encode() if code else None
await self.send_device_command(
command=clusters.DoorLock.Commands.LockDoor(code_bytes)
)

async def async_unlock(self, **kwargs: Any) -> None:
"""Unlock the lock with pin if needed."""
await self.send_device_command(command=clusters.DoorLock.Commands.UnlockDoor())
code: str = kwargs.get(
ATTR_CODE,
self._lock_option_default_code,
)
code_bytes = code.encode() if code else None
await self.send_device_command(
command=clusters.DoorLock.Commands.UnlockDoor(code_bytes)
)

@callback
def _update_from_device(self) -> None:
Expand Down