Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming of MQTT entities to correspond with HA guidelines #95159

Merged
merged 17 commits into from
Jul 21, 2023

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jun 24, 2023

Breaking change

The way MQTT entities are named and how device configuration can be shared between discovered entities has changed

Sharing of device configuration

Discovered MQTT entities can share device configuration, meaning one entity can include the full device configuration and other entities can link to that device by only setting mandatory fields.
The mandatory fields were previously limited to at least one of connection and identifiers, but has now been extended to at least one of connection and identifiers as well as the name.

Naming of MQTT entities

Naming of MQTT entities has been changed to be aligned with the entity naming guidelines:

  • The has_entity_name entity will be set to True on all MQTT entities
  • This means any MQTT entity which is part of a device will automatically have it's friendly_name attribute prefixed with the device name
  • Unnamed binary_sensor, button, number and sensor entities will now be named by their device class instead of being named "MQTT binary sensor" etc.
  • It's now allowed to set an MQTT entity's name to None to mark it as the main feature of a device

Proposed change

Change naming of MQTT entities to better correspond with the current guidelines in https://developers.home-assistant.io/docs/core/entity/#entity-naming

Always set the has_entity_name attribute on MQTT entities to True.

If a device_class is set and the entity name is not set, it follows the device class name.
The changed behavior for the generation the default entity_id is documented in the linked docs PR.

The name and in MQTT entity can now also explicitly be set to None (or null in a JSON discovery payload).
This will avoid inherit the device name as friendly name.

Link blog post PR: home-assistant/developers.home-assistant#1851

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jbouwh jbouwh changed the title Set use device_name over default name set on MQTT entities Use device_name over default name set on MQTT entities Jun 24, 2023
@jbouwh jbouwh changed the title Use device_name over default name set on MQTT entities Use device_name over default name on MQTT entities Jun 24, 2023
@jbouwh jbouwh marked this pull request as ready for review June 27, 2023 11:36
@jbouwh jbouwh requested a review from emontnemery as a code owner June 27, 2023 11:36
@jbouwh jbouwh marked this pull request as draft June 27, 2023 11:41
@jbouwh jbouwh marked this pull request as ready for review June 27, 2023 16:03
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/mixins.py Show resolved Hide resolved
@jbouwh jbouwh marked this pull request as draft June 28, 2023 18:34
@jbouwh jbouwh changed the title Use device_name over default name on MQTT entities Use device_name over default name on MQTT entities or rename after device_class Jun 28, 2023
@jbouwh jbouwh marked this pull request as ready for review June 30, 2023 10:26
@jbouwh jbouwh marked this pull request as draft June 30, 2023 15:32
@jbouwh jbouwh marked this pull request as ready for review June 30, 2023 17:47
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
@jbouwh jbouwh marked this pull request as ready for review July 20, 2023 12:09
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/mixins.py Show resolved Hide resolved
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 21, 2023 08:48
@jbouwh jbouwh marked this pull request as ready for review July 21, 2023 09:06
@jbouwh jbouwh changed the title Change naming of MQTT entities to better correspond with HA guidelines Change naming of MQTT entities to correspond with HA guidelines Jul 21, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbouwh 👍

@jbouwh jbouwh merged commit 447fbf5 into home-assistant:dev Jul 21, 2023
51 checks passed
@jbouwh jbouwh deleted the mqtt-default-entity-name branch July 21, 2023 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants