Skip to content

pyWeMo serialnumber is deprecated, use serial_number#94791

Merged
balloob merged 1 commit into
home-assistant:devfrom
esev:wemo_serial_number
Jun 18, 2023
Merged

pyWeMo serialnumber is deprecated, use serial_number#94791
balloob merged 1 commit into
home-assistant:devfrom
esev:wemo_serial_number

Conversation

@esev
Copy link
Copy Markdown
Contributor

@esev esev commented Jun 17, 2023

Proposed change

Rename serialnumber to serial_number in the wemo component. serialnumber was deprecated in pyWeMo 0.8.0 and will be removed in a future release.

HomeAssistant is currently using pywemo 0.9.1 which supports both serialnumber and serial_number.

"requirements": ["pywemo==0.9.1"],

serialnumber transitional wrapper: https://github.com/pywemo/pywemo/blob/0.9.1/pywemo/ouimeaux_device/__init__.py#L688

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob merged commit 7f7b7ae into home-assistant:dev Jun 18, 2023
@esev esev deleted the wemo_serial_number branch June 18, 2023 01:00
ocalvo pushed a commit to ocalvo/home-assistant that referenced this pull request Jun 18, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants