Skip to content

mqtt_statestream: Update to append 'state' to topic for mqtt_discovery#9446

Merged
balloob merged 1 commit into
home-assistant:devfrom
mw-white:mqtt_statestream_state
Sep 16, 2017
Merged

mqtt_statestream: Update to append 'state' to topic for mqtt_discovery#9446
balloob merged 1 commit into
home-assistant:devfrom
mw-white:mqtt_statestream_state

Conversation

@mw-white
Copy link
Copy Markdown
Contributor

Description:

This patch updates the mqtt_statestream component to append /state at the end of the publish topic. After discussion in the forum of adding publishing of attributes and mqtt discovery data, it makes sense to make this change now before the component is published to avoid the need for a breaking change later if/when the other capabilities are added.

For example, given the base_topic of homeassistant, the state of an entity called light.master_bedroom would be published to homeassistant/light/master_bedroom/state. In the future, attributes would be published at this same level (ie. homeassistant/light/master_bedroom/brightness).

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3379

Example entry for configuration.yaml (if applicable):

mqtt_statestream:
  base_topic: homeassistant

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 04bed51 into home-assistant:dev Sep 16, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented Sep 16, 2017

Thanks! 🐬

@balloob balloob mentioned this pull request Sep 22, 2017
@mw-white mw-white deleted the mqtt_statestream_state branch September 24, 2017 04:54
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants