mqtt_statestream: Update to append 'state' to topic for mqtt_discovery#9446
Merged
Conversation
…th mqtt discovery
balloob
approved these changes
Sep 16, 2017
Member
|
Thanks! 🐬 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This patch updates the mqtt_statestream component to append
/stateat the end of the publish topic. After discussion in the forum of adding publishing of attributes and mqtt discovery data, it makes sense to make this change now before the component is published to avoid the need for a breaking change later if/when the other capabilities are added.For example, given the base_topic of
homeassistant, the state of an entity calledlight.master_bedroomwould be published tohomeassistant/light/master_bedroom/state. In the future, attributes would be published at this same level (ie.homeassistant/light/master_bedroom/brightness).Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3379
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass