Ios notify camera fix#9427
Merged
Merged
Conversation
houndci-bot
reviewed
Sep 14, 2017
| else: | ||
| expose = False | ||
| if explicit_expose: | ||
| _LOGGER.warning("The attribute 'emulated_hue' is deprecated and will be removed in a" |
There was a problem hiding this comment.
line too long (97 > 79 characters)
| if explicit_expose is True or explicit_hidden is False : | ||
| expose = True | ||
| else: | ||
| expose = False |
There was a problem hiding this comment.
indentation is not a multiple of four
|
|
||
| explicit_hidden = entity.attributes.get (ATTR_EMULATED_HUE_HIDDEN, None) | ||
| if explicit_expose is True or explicit_hidden is False : | ||
| expose = True |
There was a problem hiding this comment.
indentation is not a multiple of four
| explicit_expose = entity.attributes.get(ATTR_EMULATED_HUE, None) | ||
|
|
||
| explicit_hidden = entity.attributes.get (ATTR_EMULATED_HUE_HIDDEN, None) | ||
| if explicit_expose is True or explicit_hidden is False : |
| domain = entity.domain.lower() | ||
| explicit_expose = entity.attributes.get(ATTR_EMULATED_HUE, None) | ||
|
|
||
| explicit_hidden = entity.attributes.get (ATTR_EMULATED_HUE_HIDDEN, None) |
There was a problem hiding this comment.
whitespace before '('
line too long (80 > 79 characters)
pvizeli
approved these changes
Sep 17, 2017
Merged
Contributor
|
The docs also need to be updated to reflect the changes. It is not clear right now which one should be lowercase and which one should be upper case. Thanks! |
This was referenced Sep 23, 2017
fabaff
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Sep 24, 2017
This was applied as a part of home-assistant/core#9427
fabaff
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Sep 26, 2017
This was applied as a part of home-assistant/core#9427
jnewland
pushed a commit
to jnewland/ha-config
that referenced
this pull request
Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is an attempt to fix #8693 I am looking for insight as this is would be a breaking change requiring all message identifiers to be changed to lowercase.
The issue with the current IOS code looks for the camera message type to be lowercase however the HASS ios.py converts all message types to upper. An eaiser fix would be to change the IOS app code to look for uppercase identifiers but I am not sure if the code is maintained anymore or can be updated.
Can any of the more experienced devs chime in?
The IOS app code is here: https://github.com/home-assistant/home-assistant-iOS/blob/f4b7789cbd46c38f9bc1a47fa9186742b24a41df/APNSAttachmentService/NotificationService.swift#L49
Related issue (if applicable): fixes #8693
Forum post. https://community.home-assistant.io/t/ios-actionable-notification-with-camera-image-attached/13581/24
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass