Skip to content

Command line flag to control logging output file#9422

Merged
balloob merged 1 commit into
home-assistant:devfrom
TD22057:log_file
Sep 14, 2017
Merged

Command line flag to control logging output file#9422
balloob merged 1 commit into
home-assistant:devfrom
TD22057:log_file

Conversation

@TD22057
Copy link
Copy Markdown
Contributor

@TD22057 TD22057 commented Sep 14, 2017

Description:

Add a hass command line flag to control where the log file is written to. If not set, the current system (CONFIG/home-assistant.log) is used. This allows users to control where the log file is written to. Many/most Linux app logs are written to /var/log. On the Pi, it's useful to have logs written to a ram disk to avoid wearing the SD card. Original feature request thread is here.

Pull request in home-assistant (if applicable): home-assistant/home-assistant.io#3365

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@TD22057 TD22057 requested a review from a team as a code owner September 14, 2017 03:15
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @TD22057,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 🐬

@balloob balloob merged commit 411c962 into home-assistant:dev Sep 14, 2017
@TD22057 TD22057 deleted the log_file branch September 14, 2017 15:08
@balloob balloob mentioned this pull request Sep 22, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants