Skip to content

Fix displaying of friendly_name for light template component#9413

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
rollbrettler:fix-light-template-name
Sep 14, 2017
Merged

Fix displaying of friendly_name for light template component#9413
pvizeli merged 1 commit into
home-assistant:devfrom
rollbrettler:fix-light-template-name

Conversation

@rollbrettler
Copy link
Copy Markdown
Contributor

@rollbrettler rollbrettler commented Sep 13, 2017

Description:

Currently the friendly name for the light template component is not accessible.

** Pull request in home-assistant.github.io with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here> already documented

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @rollbrettler,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@rollbrettler
Copy link
Copy Markdown
Contributor Author

sure, done!

@pvizeli pvizeli merged commit 371d1cc into home-assistant:dev Sep 14, 2017
@rollbrettler rollbrettler deleted the fix-light-template-name branch September 14, 2017 11:14
@balloob balloob mentioned this pull request Sep 22, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants