Skip to content

full RGB support for users of tradfri GW #9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Sep 14, 2017
Merged

full RGB support for users of tradfri GW #9411

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc3d51
Update tradfri.py
spektren Sep 13, 2017
d3ce83a
Update tradfri.py
spektren Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions homeassistant/components/light/tradfri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,12 @@ def turn_on(self, **kwargs):
self._api(self._light_control.set_state(True))

if ATTR_RGB_COLOR in kwargs and self._light_data.hex_color is not None:
self._api(self._light.light_control.set_hex_color(
color_util.color_rgb_to_hex(*kwargs[ATTR_RGB_COLOR])))
#~ self._api(self._light.light_control.set_hex_color(

@houndci-bot houndci-bot Sep 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block comment should start with '# '

#~ color_util.color_rgb_to_hex(*kwargs[ATTR_RGB_COLOR])))

@houndci-bot houndci-bot Sep 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block comment should start with '# '

## 201709013: set_hex_color() seems not to work in pytradfri api - set_rgb_color() does

@houndci-bot houndci-bot Sep 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many leading '#' for block comment
line too long (99 > 79 characters)
trailing whitespace

## -> changed function set_hex_color() to set_rgb_color()

@houndci-bot houndci-bot Sep 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many leading '#' for block comment

## tested w. IKEA tradfri GW and zigbee rgb PWM module (dresden elektronik FLS-PP lp)

@houndci-bot houndci-bot Sep 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many leading '#' for block comment
line too long (97 > 79 characters)
trailing whitespace

self._api(self._light.light_control.set_rgb_color(*kwargs[ATTR_RGB_COLOR]))

@houndci-bot houndci-bot Sep 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (87 > 79 characters)


elif ATTR_COLOR_TEMP in kwargs and \
self._light_data.hex_color is not None and self._ok_temps:
Expand Down