Skip to content

Clean up error logging in qbittorrent #94071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 1 commit into from
Jun 5, 2023
Merged

Clean up error logging in qbittorrent #94071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions homeassistant/components/qbittorrent/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
entry.data[CONF_VERIFY_SSL],
)
except LoginRequired as err:
_LOGGER.error("Invalid credentials")
raise ConfigEntryNotReady from err
raise ConfigEntryNotReady("Invalid credentials") from err
Copy link
Copy Markdown
Contributor

@epenet epenet Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: is there a plan to implement reauth?

Copy link
Copy Markdown
Contributor Author

@chrisx8 chrisx8 Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at this moment, but I'll look into it when I have more time.

except RequestException as err:
_LOGGER.error("Failed to connect")
raise ConfigEntryNotReady from err
raise ConfigEntryNotReady("Failed to connect") from err

await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)
return True
Expand Down