Break up Alexa per functionality#9400
Merged
Merged
Conversation
houndci-bot
reviewed
Sep 12, 2017
| from homeassistant.core import callback | ||
| from homeassistant.setup import async_setup_component | ||
| from homeassistant.components import alexa | ||
| from homeassistant.components.alexa import const, intent |
There was a problem hiding this comment.
'homeassistant.components.alexa.const' imported but unused
|
|
||
| req = yield from _flash_briefing_req(alexa_client, "news_audio") | ||
| assert req.status == 200 | ||
| json = yield from req.json() |
There was a problem hiding this comment.
redefinition of unused 'json' from line 4
| from homeassistant.core import callback | ||
| from homeassistant.setup import async_setup_component | ||
| from homeassistant.components import alexa | ||
| from homeassistant.components.alexa import const, intent |
There was a problem hiding this comment.
'homeassistant.components.alexa.intent' imported but unused
| """The tests for the Alexa component.""" | ||
| # pylint: disable=protected-access | ||
| import asyncio | ||
| import json |
pvizeli
approved these changes
Sep 12, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
No functionality change, just a refactor to clean up Alexa code.
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass