Support specifying no Apple TVs#9394
Merged
Merged
Conversation
balloob
approved these changes
Sep 13, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In order to use the scan functionality in the Apple TV platform, the actual platform must be loaded. This is not possible as the input validation requires at least one device to be added (and some other minor changes).
I tried to use
ensure_listto validate this, but if nothing is specified an empty dict ({}) is passed to the validator which just wraps it in a list triggers validation of a device. I added my own version ofensure_listthat interprets an empty dict as no item at all to cover this special case. I'm not sure this is a good solution so it would be good if someone commented on this.Related issue (if applicable): fixes #9362
Example entry for
configuration.yaml(if applicable):apple_tv:Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.