Skip to content

fix mopar sensor #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Sep 13, 2017
Merged

fix mopar sensor #9389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5e63a7
fix mopar sensor
happyleavesaoc Sep 11, 2017
4499db6
fix typo
happyleavesaoc Sep 11, 2017
b171dd2
bump mopar dep version
happyleavesaoc Sep 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/sensor/mopar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import homeassistant.helpers.config_validation as cv


REQUIREMENTS = ['motorparts==1.0.0']
REQUIREMENTS = ['motorparts==1.0.2']

_LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -86,6 +86,7 @@ def __init__(self, session):
self.vehicles = []
self.vhrs = {}
self.tow_guides = {}
self.update()
Copy link
Copy Markdown
Member

@balloob balloob Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By passing True as second argument to add_devices, Home Assistant will call update() before adding it to Home Assistant. So I'm not 100% sure how this can fix it 🤔

Copy link
Copy Markdown
Member

@balloob balloob Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I do believe you if you say that it fixes it, I just don't understand how)


@Throttle(MIN_TIME_BETWEEN_UPDATES)
def update(self, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ miflora==0.1.16
miniupnpc==1.9

# homeassistant.components.sensor.mopar
motorparts==1.0.0
motorparts==1.0.2

# homeassistant.components.tts
mutagen==1.38
Expand Down