Skip to content

Basic MQTT vacuum support #9386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 15 commits into from
Sep 15, 2017
Merged

Basic MQTT vacuum support #9386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1d3cfd1
Basic MQTT vacuum support
johnboiles Sep 5, 2017
43dc1a6
PR feedback
johnboiles Sep 13, 2017
2009409
Support for fan_speed and send_command services
johnboiles Sep 13, 2017
d2bd84a
Fix configurable topics
johnboiles Sep 13, 2017
d04eac8
Use configurable bools for cleaning/docked/stopped state
johnboiles Sep 13, 2017
50793a3
Fix language in docstring
johnboiles Sep 13, 2017
639391c
PR feedback
johnboiles Sep 13, 2017
0f4cefd
Remove duplicate vacuum/state topic defaults
johnboiles Sep 13, 2017
fb24fdf
Fix incorrect template for docked value
johnboiles Sep 13, 2017
60d9f71
Move direction like default mqtt platfom/components
pvizeli Sep 15, 2017
0a17fbe
fix None on templates
pvizeli Sep 15, 2017
cf94712
fix tests
pvizeli Sep 15, 2017
bbe2b4b
fix int
pvizeli Sep 15, 2017
15c74e9
fix tests
pvizeli Sep 15, 2017
7fd1c10
ready to merge
pvizeli Sep 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,7 @@ omit =
homeassistant/components/weather/zamg.py
homeassistant/components/zeroconf.py
homeassistant/components/zwave/util.py
homeassistant/components/vacuum/mqtt.py


[report]
Expand Down
6 changes: 3 additions & 3 deletions homeassistant/components/vacuum/demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def turn_off(self, **kwargs):
self.schedule_update_ha_state()

def stop(self, **kwargs):
"""Turn the vacuum off."""
"""Stop the vacuum."""
if self.supported_features & SUPPORT_STOP == 0:
return

Expand All @@ -162,7 +162,7 @@ def clean_spot(self, **kwargs):
self.schedule_update_ha_state()

def locate(self, **kwargs):
"""Turn the vacuum off."""
"""Locate the vacuum (usually by playing a song)."""
if self.supported_features & SUPPORT_LOCATE == 0:
return

Expand All @@ -184,7 +184,7 @@ def start_pause(self, **kwargs):
self.schedule_update_ha_state()

def set_fan_speed(self, fan_speed, **kwargs):
"""Tell the vacuum to return to its dock."""
"""Set the vacuum's fan speed."""
if self.supported_features & SUPPORT_FAN_SPEED == 0:
return

Expand Down
Loading